Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Change Redshift Cluster cluster_type to be computed #5238

Merged
merged 1 commit into from
Feb 22, 2016
Merged

provider/aws: Change Redshift Cluster cluster_type to be computed #5238

merged 1 commit into from
Feb 22, 2016

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 21, 2016

It will be based off the number of nodes. Can only be multi-node (>1 node) or single-node (nodes=1)

As requested in #5235

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRedshiftCluster' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
GO15VENDOREXPERIMENT=1 go generate $(GO15VENDOREXPERIMENT=1 go list ./... | grep -v /vendor/)
TF_ACC=1 GO15VENDOREXPERIMENT=1 go test ./builtin/providers/aws -v -run=TestAccAWSRedshiftCluster -timeout 120m
=== RUN   TestAccAWSRedshiftCluster_basic
--- PASS: TestAccAWSRedshiftCluster_basic (598.03s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    598.047s

@stack72
provider/aws: Change Redshift Cluster cluster_type to be computed
e6e18a4 
It will be based off the number of nodes. Can only be multi-node (>1
node) or single-node (nodes=1)
@stack72 stack72 mentioned this pull request Feb 21, 2016
Closed
@jen20 jen20 added this to the Terraform 0.6.12 milestone Feb 22, 2016
@jen20
Copy link
Contributor

jen20 commented Feb 22, 2016

LGTM. Thanks @stack72! Fixes #5235.

jen20 added a commit that referenced this pull request Feb 22, 2016
@jen20
Merge pull request #5238 from stack72/f-aws-redshift-calculate-cluster
16b18df 
provider/aws: Change Redshift Cluster cluster_type to be computed
@jen20 jen20 merged commit 16b18df into hashicorp:master Feb 22, 2016
@mmccord-mdbuyline mmccord-mdbuyline mentioned this pull request Dec 12, 2019
Closed
@ghost ghost mentioned this pull request Dec 12, 2019
Open
@ghost
Copy link

ghost commented Apr 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stack72 @jen20